Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agents.md #2070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

spacewaterbear
Copy link

fix bad typing in RetrieverTool class

fix bad typing in RetrieverTool class
@@ -184,7 +184,7 @@ class RetrieverTool(Tool):
}
output_type = "text"

def __init__(self, vectordb: VectorStore, all_sources: str, **kwargs):
def __init__(self, vectordb: VectorStore, all_sources: list[str], **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the comment in L191 says it's a string representation of a list, but both that and a list should work. cc @aymeric-roucher to use whichever one he thinks it's best.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both List[str] and str should work, so this line could be Union[str, List[str]]!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants